Re: executor relation handling

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: Amit Langote <amitlangote09(at)gmail(dot)com>, Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>
Cc: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: executor relation handling
Date: 2018-09-13 04:58:05
Message-ID: 12038780-e196-e6d2-774e-68e4de8b2fc7@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 2018/09/13 0:23, Amit Langote wrote:
> On Wed, Sep 12, 2018 at 9:23 PM, Jesper Pedersen
> <jesper(dot)pedersen(at)redhat(dot)com> wrote:
>> Hi Amit,
>>
>> On 9/12/18 1:23 AM, Amit Langote wrote:
>>>
>>> Please find attached revised patches.
>>>
>>
>> After applying 0004 I'm getting a crash in 'eval-plan-qual' during
>> check-world using
>>
>> export CFLAGS="-DCOPY_PARSE_PLAN_TREES -O0 -fno-omit-frame-pointer" &&
>> ./configure --enable-dtrace --with-openssl --with-gssapi --with-libxml
>> --with-llvm --enable-debug --enable-depend --enable-tap-tests
>> --enable-cassert
>>
>> Confirmed by CFBot in [1].
>>
>> [1] https://travis-ci.org/postgresql-cfbot/postgresql/builds/427530296
>
> Thanks Jesper. Will look into it first thing tomorrow morning.

Attached updated patches.

Beside the issue that caused eval-plan-qual isolation test to crash, I
also spotted and fixed an oversight in the 0002 patch which would lead to
EState.es_output_cid being set to wrong value and causing unexpected error
during tuple locking as result of that.

Thanks,
Amit

Attachment Content-Type Size
v4-0001-Don-t-lock-range-table-relations-in-the-executor.patch text/plain 41.3 KB
v4-0002-Remove-useless-fields-from-planner-nodes.patch text/plain 37.4 KB
v4-0003-Prune-PlanRowMark-of-relations-that-are-pruned-fr.patch text/plain 2.4 KB
v4-0004-Revise-executor-range-table-relation-opening-clos.patch text/plain 36.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2018-09-13 06:28:00 Re: simplify index tuple descriptor initialization
Previous Message Amit Langote 2018-09-13 04:38:05 Re: Getting ERROR: could not open file "base/13164/t3_16388" with partition table with ON COMMIT