Re: [sqlsmith] Crash in tsquery_rewrite/QTNBinary

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Artur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>
Cc: Andreas Seltenreich <seltenreich(at)gmx(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [sqlsmith] Crash in tsquery_rewrite/QTNBinary
Date: 2016-12-11 18:12:24
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Artur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru> writes:
> 2016-12-07 9:06 GMT+03:00 Andreas Seltenreich <seltenreich(at)gmx(dot)de>:
>> the following query crashes master as of 4212cb7.

> It happens because 'I' is stop word and substitute query becomes
> empty. And for queries above we need recursive dropvoidsubtree()
> function. Without this patch this function cleans only first level of
> tree. And query above becomes: '6 | void'.

> Firstly I made recursive dropvoidsubtree(). But attached patch cleans
> query tree in dofindsubquery() to avoid extra tree scan.

This patch looks good to me. I have to admit that I'd been suspicious
of dropvoidsubtree() the last time I looked at this code, but I didn't
have adequate reason to touch it. Pushed with some minor comment

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2016-12-11 18:20:18 Re: Optimization for index-only scans with filter conditions
Previous Message Mateusz Stefek 2016-12-11 17:56:39 Optimization for index-only scans with filter conditions