| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, pgsql-hackers(at)postgresql(dot)org, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, David Steele <david(at)pgmasters(dot)net>, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: pg11+: pg_ls_*dir LIMIT 1: temporary files .. not closed at end-of-transaction |
| Date: | 2020-03-31 16:41:50 |
| Message-ID: | 11882.1585672910@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Justin Pryzby <pryzby(at)telsasoft(dot)com> writes:
> I suggest to leave stat() alone in your patch for stable releases. I think
> it's okay if we change behavior so that a broken symlink is skipped instead of
> erroring (as a side effect of skipping ENOENT with stat()). But not okay if we
> change pg_ls_logdir() to hide symlinks in back braches.
Meh. I'm not really convinced, but in the absence of anyone expressing
support for my position, I'll do it that way. I don't think it's worth
doing both a stat and lstat to tell the difference between file-is-gone
and file-is-a-broken-symlink.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | James Coleman | 2020-03-31 16:43:14 | Re: [PATCH] Incremental sort (was: PoC: Partial sort) |
| Previous Message | Alexey Bashtanov | 2020-03-31 16:34:01 | Re: Less-silly selectivity for JSONB matching operators |