Skip site navigation (1) Skip section navigation (2)

Re: HOT patch - version 11

From: "Simon Riggs" <simon(at)2ndquadrant(dot)com>
To: "Heikki Linnakangas" <heikki(at)enterprisedb(dot)com>
Cc: "Pavan Deolasee" <pavan(dot)deolasee(at)gmail(dot)com>,"PostgreSQL-patches" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: HOT patch - version 11
Date: 2007-08-02 14:37:32
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackerspgsql-patches
On Wed, 2007-08-01 at 21:09 +0100, Heikki Linnakangas wrote:

> In heap_page_prune_defrag, it would be better to do the test for
> BufferIsLockedForCleanup right after acquiring the lock. The longer the
> delay between those steps, the bigger the chances that someone pins the
> page and starts to wait for the buffer lock, making us think that we
> didn't get the cleanup lock, though we actually did. Maybe a nicer
> solution would be to have another version of ConditionalLockBuffer with
> three different return values: didn't get lock, got exclusive lock, or
> got cleanup lock.

Yeh, 3-value return seems neatest way.

  Simon Riggs

In response to

pgsql-hackers by date

Next:From: Josh BerkusDate: 2007-08-02 14:58:45
Subject: clog_buffers to 64 in 8.3?
Previous:From: Andrei KovalevskiDate: 2007-08-02 12:57:31
Subject: Re: .NET driver

pgsql-patches by date

Next:From: Neil ConwayDate: 2007-08-02 17:50:46
Subject: Re: Memory leak in tuplestore_end()
Previous:From: Andrew DunstanDate: 2007-08-02 07:56:25
Subject: Re: enable logging of start time/cookie for all backend processes

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group