| From: | "Simon Riggs" <simon(at)2ndquadrant(dot)com> |
|---|---|
| To: | "Alvaro Herrera" <alvherre(at)commandprompt(dot)com> |
| Cc: | <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: Fast CLUSTER |
| Date: | 2007-02-22 22:49:10 |
| Message-ID: | 1172184550.3874.196.camel@silverbirch.site |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
On Tue, 2007-02-20 at 14:38 -0300, Alvaro Herrera wrote:
> Cool. I noticed that the SGML seems broken here:
Corrected.
> You need to close the <listitem> and <para> opened in the COPY mention.
>
> > +
> > + static void
> > + heap_sync_relation(Relation rel)
> > + {
> > + if (!rel->rd_istemp)
>
> No comment in this function?
I've added more comments as you suggest.
Thanks for the review.
--
Simon Riggs
EnterpriseDB http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| fast_cluster.v2.patch | text/x-patch | 10.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jim C. Nasby | 2007-02-23 06:28:20 | Re: [HACKERS] HOT WIP Patch - version 2 |
| Previous Message | Guillaume Smet | 2007-02-22 22:17:45 | Re: First implementation of GIN for pg_trgm |