Re: Re: [PATCHES] Patch to support transactions with BLOBs for current CVS

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Denis Perchine <dyp(at)perchine(dot)com>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [PATCHES] Patch to support transactions with BLOBs for current CVS
Date: 2001-01-21 04:39:52
Message-ID: 11543.980051992@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Can people comment on the following patch that Dennis says is needed?

I object strongly. As given, this would break lo_creat, lo_unlink,
lo_import, and lo_export --- none of which need to be in a transaction
block --- not to mention possibly causing gratuitous failures during
lo_commit.

I'm not convinced that we need such a check at all; I don't see anything
especially wrong with the existing behavior. But if we do want it, this
is the wrong abstraction level. be-fsstubs.c is the place to do it,
and only in the routines that take or return an open-LO descriptor.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Steve Howe 2001-01-21 05:04:41 This script will crash the connection
Previous Message Bruce Momjian 2001-01-21 03:58:40 Re: Re: [PATCHES] Patch to support transactions with BLOBs for current CVS

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2001-01-21 05:16:10 Fix for defaults in createuser
Previous Message Bruce Momjian 2001-01-21 03:58:40 Re: Re: [PATCHES] Patch to support transactions with BLOBs for current CVS