| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: TAP tests vs log_error verbosity=verbose |
| Date: | 2022-07-31 16:14:56 |
| Message-ID: | 1153281.1659284096@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> Twice recently (b998196bb5 and 19408aae7f) I have had to adjust new TAP
> tests to handle log_error_verbosity=verbose, and there's a third case
> needing adjustment in the new auto_explain tests (7c34555f8c). I'm
> wondering if it would be better to set log_error_verbosity to default
> for TAP tests, no matter what's in TEMP_CONFIG. An individual TAP test
> could still set log_error_verbosity=verbose explicitly if it wanted it.
> If not I'm going to change one of my buildfarm animals to use
> log_error_verbosity=verbose so we catch things like this earlier.
I think it's good to be able to enable log_error_verbosity=verbose
in case you need to track down some kind of problem. So I'd vote
for your second approach.
7c34555f8c is mine, so I'll go fix that.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Gianluca Calcagni | 2022-07-31 16:39:11 | Triggers should work in isolation, with a final conflict detection step |
| Previous Message | Andrew Dunstan | 2022-07-31 16:10:24 | TAP tests vs log_error verbosity=verbose |