On Wed, 2006-01-11 at 23:31 -0500, Tom Lane wrote:
> This is a good catch, but the patch's added check on targetTyptype is a
> waste of code and cycles. coerce_to_domain is perfectly capable of
> doing nothing when nothing is called for.
Ah, right. Attached is a corrected patch.
> I wonder whether there is any reasonably simple way to audit the whole
> backend for missing domain processing...
Yeah, I've been thinking along the same lines -- the recent spate of
issues doesn't give me a lot of confidence in the correctness or
completeness of the current implementation. I don't really see a way to
check the code that doesn't require a fair amount of manual auditing,
In response to
pgsql-patches by date
|Next:||From: Tom Lane||Date: 2006-01-12 05:45:56|
|Subject: Re: domain constraints and UNKNOWN params |
|Previous:||From: ITAGAKI Takahiro||Date: 2006-01-12 05:22:41|
|Subject: Re: Free WAL caches on switching segments|