Skip site navigation (1) Skip section navigation (2)

Re: add_missing_from breaks existing views

From: Neil Conway <neilc(at)samurai(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: add_missing_from breaks existing views
Date: 2005-10-25 21:58:52
Message-ID: 1130277532.8506.87.camel@localhost.localdomain (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
On Tue, 2005-25-10 at 17:43 -0400, Tom Lane wrote:
> What I suggest we do about this is change addImplicitRTE() to set
> inFromCl true for implicitly added RTEs, so that the view rule will
> later be dumped as if the query had been written per spec.

Sounds reasonable. I wonder if this should be backpatched -- ISTM the
proper representation of the view is with an explicit FROM list anyway,
and making the correctness of view definition dependent on a GUC
variable is only asking for trouble.

> 1. Tell people they may have to set add_missing_from = true to reload
> a dump that contains such views.

pg_dump could itself specify "SET add_missing_from = true" before view
definitions. However, that is definitely a hack :(


In response to


pgsql-hackers by date

Next:From: Simon RiggsDate: 2005-10-25 23:13:43
Subject: Re: add_missing_from breaks existing views
Previous:From: Tom LaneDate: 2005-10-25 21:55:21
Subject: Re: expanded \df+ display broken in beta4

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group