Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Fix linking of OpenLDAP libraries

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Albe Laurenz" <all(at)adv(dot)magwien(dot)gv(dot)at>
Cc: pgsql-patches(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [HACKERS] Fix linking of OpenLDAP libraries
Date: 2006-09-04 19:41:33
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackerspgsql-patches
"Albe Laurenz" <all(at)adv(dot)magwien(dot)gv(dot)at> writes:

>   # The backend doesn't need everything that's in LIBS, however
> ! LIBS := $(filter-out -lz -lreadline -ledit -ltermcap -lncurses -lcurses -lldap_r $(PTHREAD_LIBS), $(LIBS))

This seems pretty risky.  What if PTHREAD_LIBS contains -L switches?
They'd get removed even if needed for other libraries.

It would probably be safer not to put LDAP into LIBS at all, but invent
two new macros for configure to set, say LDAP_LIBS and LDAP_LIBS_R,
and add these to the link lines in the backend and libpq respectively.

			regards, tom lane

In response to

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2006-09-04 19:44:39
Subject: Re: [COMMITTERS] pgsql: sslinfo contrib module -
Previous:From: Bruce MomjianDate: 2006-09-04 19:41:01
Subject: Re: TODO Item : GRANT/REVOKE to all schema objects

pgsql-patches by date

Next:From: Bruce MomjianDate: 2006-09-04 19:46:03
Subject: Re: Backend SSL configuration enhancement
Previous:From: Bruce MomjianDate: 2006-09-04 19:35:49
Subject: Re: [HACKERS] Interval month, week -> day

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group