Re: Yet another fast GiST build

From: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Darafei Komяpa Praliaskouski <me(at)komzpa(dot)net>, Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Yet another fast GiST build
Date: 2020-11-07 15:42:31
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> 5 нояб. 2020 г., в 22:20, Justin Pryzby <pryzby(at)telsasoft(dot)com> написал(а):
> On Thu, Nov 05, 2020 at 10:11:52PM +0500, Andrey Borodin wrote:
>> To test that functions are actually called for sorting build we should support directive sorting build like "CREATE INDEX ON A USING GIST(B) WITH(sorting=surely,and fail if not)".
> Maybe you could add a DEBUG1 message for that, and include that in regression
> tests, which would then fail if sorting wasn't used.

That's a good idea. Thanks!
> Maybe you'd need to make it consistent by setting GUCs like work_mem /
> max_parallel_maintenance_workers / ??
> Similar to this
> postgres=# SET client_min_messages =debug;
> postgres=# CREATE INDEX ON A USING GIST(i) WITH(buffering=off);
> DEBUG: building index "a_i_idx2" on table "a" serially

Currently, only B-tree uses parallel build, so no need to tweak GUCs except client_min_messages.
Before these tests, actually, ~20% of opclasses were not working as expected. Despite I've checked each one by hand. I have

PFA patch with fixed comments from Heikki.


Best regards, Andrey Borodin.

Attachment Content-Type Size
v4-0001-Sortsupport-for-sorting-GiST-build-for-gist_btree.patch application/octet-stream 81.6 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-11-07 16:57:20 Rethinking LOCK TABLE's behavior on views
Previous Message Bharath Rupireddy 2020-11-07 14:01:21 Re: Use standard SIGHUP and SIGTERM handlers in autoprewarm module