Skip site navigation (1) Skip section navigation (2)

Re: relscan.h split

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Pg Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: relscan.h split
Date: 2008-06-12 17:04:47
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-patches
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> I propose the following patch which moves the struct definitions to a
> separate new header relscan_internal.h.

This seems a little bizarre, seeing that there is almost nothing in
relscan.h except those structs.

Perhaps a better idea would be to put the opaque-pointer typedefs into
heapam.h and genam.h respectively, and then see where you could remove
inclusions of relscan.h.

Also, it seemed like some of those .c files had no business poking into
the scan structs anyway; particularly contrib.  Did you check whether
the inclusions could be avoided?

			regards, tom lane

In response to


pgsql-patches by date

Next:From: Alvaro HerreraDate: 2008-06-12 17:35:02
Subject: Re: Tentative patch for making DROP put dependency infoin DETAIL
Previous:From: Alvaro HerreraDate: 2008-06-12 16:40:43
Subject: relscan.h split

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group