| From: | "Jaroslaw J(dot) Pyszny" <arghil(at)poczta(dot)onet(dot)pl> |
|---|---|
| To: | Kris Jurka <books(at)ejurka(dot)com> |
| Cc: | pgsql-jdbc <pgsql-jdbc(at)postgresql(dot)org> |
| Subject: | Re: Auto-increment serial (Postgresql JDBC driver w/ |
| Date: | 2004-09-21 19:25:48 |
| Message-ID: | 1095794747.18680.23.camel@lx.siec |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-jdbc |
W liście z wto, 21-09-2004, godz. 03:50, Kris Jurka pisze:
> On Mon, 21 Sep 2004, Jaroslaw J. Pyszny wrote:
>
> The basic idea looks good to me, but you've made a mistake in the
> isAutoIncrement() method. You are using the column number from the
> ResultSet to look up the default when you need to actually use that
> column's position in the table. In fact it looks like the whole method
> body should be moved into the Field class much like the isNullable method
> does. This also avoid the contrived hash key value.
>
> Finally we prefer patches in context diff format (diff -c).
Thanks :)
I'll try fix it.
Jarek
--
8 \\|||// Jarosław J. Pyszny <arghil(at)poczta(dot)onet(dot)pl>
b (o|o) Linux admin/devel ("Vitae,non scholae,discimus")
i --\_/-- Linux user: #96704 (http://counter.li.org)
t =->computers - let me know if you want to get rid of it <-=
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Cramer | 2004-09-21 20:31:15 | Re: Auto-increment serial (Postgresql JDBC driver w/ |
| Previous Message | Andrew Sullivan | 2004-09-21 17:49:46 | Re: "Idle in Transaction" revisited. |