Re: [PATCH] Discard aborted updaters when expanding a multixact

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Chee Wooson <wuqi(at)vastdata(dot)com(dot)cn>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: "chee(dot)wooson" <chee(dot)wooson(at)gmail(dot)com>
Subject: Re: [PATCH] Discard aborted updaters when expanding a multixact
Date: 2026-10-09 20:52:32
Message-ID: 106628f7-4084-4e5e-9b8c-45c761718beb@iki.fi
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 08/10/2026 12:04, Chee Wooson wrote:
> Hi,
>
> Since v3 no longer applied cleanly due to conflicts, I rebased it onto current master at 061065e28f0. Attached is v4.

Thanks, the fix looks correct to me.

I spend some time rewriting all the comments; I found them pretty
difficult to read. Notable, they used many words to explain that a
transaction might not be marked as committed or aborted but we have
already checked that it is not running hence it cannot commit in the
future. While that's all true, I think it's still OK, and more
understandable to a human, to just call it an "aborted transaction", or
"aborted (or crashed) transaction" if you want to call out crashed
transactions separately. That's a concept that's explained in more
detail in existing comments in heapam_visibility.c.

See attached version with my comment changes.

- Heikki

Attachment Content-Type Size
v5-0001-Fix-checks-for-aborted-updating-transaction-in-mu.patch text/x-patch 15.6 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2026-10-09 20:57:34 Re: Bypassing cursors in postgres_fdw to enable parallel plans
Previous Message Dongpo Liu 2026-10-09 20:19:25 Re: pg_*_advice: tsv load failure, etc.