Skip site navigation (1) Skip section navigation (2)

Re: syntax error position "CREATE FUNCTION" bug fix

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: syntax error position "CREATE FUNCTION" bug fix
Date: 2004-03-18 17:56:45
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackerspgsql-patches
Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> writes:
>> Moreover, I don't like the proposed protocol change anyway.  This
>> approach only solves the problem for psql-like error reporting, namely
>> clients that are going to regurgitate a string in their error message
>> and aren't very picky about whether that string really matches the
>> original input. One of the design goals for the error reporting feature
>> is that GUI-type clients should be able to mark syntax error positions
>> by highlighting in the original input window.  This proposal abandons
>> that goal.

> I cannot see your point.

> Any GUI can take advantage of the returned string to show it in a window
> with fancy colors and do any hilighting around the position.

But it cannot (easily) match it up with the *original input* and put the
cursor in the right place in the *input* window.  You are envisioning
something that's no better than psql with window borders.  My idea of a
GUI syntax error report is something that puts my editing cursor in the
right place.

> I've implemented the stuff for psql (with your help btw), but I cannot see
> why it couldn't be used with other interfaces?

It's not the right thing for other interfaces.  If it were the right
thing for all interfaces, we'd have put the functionality in the backend
to begin with.

			regards, tom lane

In response to


pgsql-hackers by date

Next:From: Andrew DunstanDate: 2004-03-18 18:23:14
Subject: Re: fsync method checking
Previous:From: Tom LaneDate: 2004-03-18 17:51:03
Subject: Re: Further thoughts about warning for costly FK checks

pgsql-patches by date

Next:From: Fabien COELHODate: 2004-03-18 19:00:29
Subject: Re: syntax error position "CREATE FUNCTION" bug fix
Previous:From: Fabien COELHODate: 2004-03-18 16:51:45
Subject: Re: syntax error position "CREATE FUNCTION" bug fix

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group