| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org, "Magnus Hagander" <mha(at)sollentuna(dot)net> |
| Cc: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: MSVC build broken (again) |
| Date: | 2006-10-03 20:01:20 |
| Message-ID: | 10542.1159905680@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
"Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
> The code around errcode is definitly messy. In CVS now, it actually
> renames *our* errcode() function to __msvc_errcode, and exports this
> from postgres.exe. This is definitly very borken.
Would it be possible to move the whole <crtdefs.h> block into win32.h?
This would cause it to be included after <stdio.h> and friends, which
maybe is too late, but taking it out of c.h would be a lot cleaner.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2006-10-03 20:01:31 | Re: vcbuild bison check |
| Previous Message | Gregory Stark | 2006-10-03 19:56:33 | Pie-in-sky dreaming about reworking tuple layout entirely |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2006-10-03 20:01:31 | Re: vcbuild bison check |
| Previous Message | Magnus Hagander | 2006-10-03 19:59:46 | pgevent fixes |