Skip site navigation (1) Skip section navigation (2)

Re: We need to log aborted autovacuums

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Greg Smith <greg(at)2ndquadrant(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: We need to log aborted autovacuums
Date: 2011-01-16 18:26:38
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
Greg Smith <greg(at)2ndquadrant(dot)com> writes:
> Tom Lane wrote:
>> No, I don't believe we should be messing with the semantics of
>> try_relation_open.  It is what it is.

> With only four pretty simple callers to the thing, and two of them 
> needing the alternate behavior, it seemed a reasonable place to modify 
> to me.  I thought the "nowait" boolean idea was in enough places that it 
> was reasonable to attach to try_relation_open.

I would be willing to do that if it actually fixed the problem, but it
doesn't.  Logging only the table OID and not the table name is entirely
inadequate IMO, so the fix has to be at a different place anyway.

			regards, tom lane

In response to

pgsql-hackers by date

Next:From: Simone AikenDate: 2011-01-16 18:47:11
Subject: Re: ToDo List Item - System Table Index Clustering
Previous:From: Magnus HaganderDate: 2011-01-16 18:22:38
Subject: Re: pg_basebackup for streaming base backups

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group