Re: speeding up planning with partitions

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: "Imai, Yoshikazu" <imai(dot)yoshikazu(at)jp(dot)fujitsu(dot)com>, "'Amit Langote'" <amitlangote09(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>
Subject: Re: speeding up planning with partitions
Date: 2019-03-20 00:41:43
Message-ID: 0c90ce90-b010-4791-41c0-a0df34f99ffa@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Imai-san,

Thanks for the review.

On 2019/03/19 20:13, Imai, Yoshikazu wrote:
> Thanks for new patches.
> I looked over them and there are little comments.
>
> [0002]
> * s/regresion/regression/g
> (in commit message.)
>
> [0003]
> * I thought "inh flag is it" is "inh flag is set" ...?
>
> + * For RTE_RELATION rangetable entries whose inh flag is it, adjust the
>
>
> * Below comments are correct when after applying 0004.
>
> + * the query's target relation and no other. Especially, children of any
> + * source relations are added when the loop below calls grouping_planner
> + * on the *1st* child target relation.
>
> [0004]
> * s/contain contain/contain/
>
> + * will contain contain references to the subquery RTEs that we've
>
>
> * s/find them children/find their children/
>
> + * AppendRelInfos needed to find them children, so the next
>
> [0006]
> * s/recursivly/recursively/
> (in commit message)
>
>
> I have no more comments about codes other than above :)

I have fixed all. Attached updated patches.

Thanks,
Amit

Attachment Content-Type Size
v33-0001-Build-other-rels-of-appendrel-baserels-in-a-sepa.patch text/plain 11.8 KB
v33-0002-Add-rowmark-junk-targetlist-entries-in-query_pla.patch text/plain 25.6 KB
v33-0003-Delay-adding-inheritance-child-tables-until-quer.patch text/plain 30.4 KB
v33-0004-Adjust-inheritance_planner-to-reuse-source-child.patch text/plain 27.2 KB
v33-0005-Further-tweak-inheritance_planner-to-avoid-usele.patch text/plain 4.7 KB
v33-0006-Perform-pruning-in-expand_partitioned_rtentry.patch text/plain 30.0 KB
v33-0007-Teach-planner-to-only-process-unpruned-partition.patch text/plain 7.6 KB
v33-0008-Don-t-copy-PartitionBoundInfo-in-set_relation_pa.patch text/plain 1.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2019-03-20 00:48:59 Re: Proposal to suppress errors thrown by to_reg*()
Previous Message Tsunakawa, Takayuki 2019-03-20 00:23:30 RE: [survey] New "Stable" QueryId based on normalized query text