Re: speeding up planning with partitions

Imai-san,

Thanks for the review.

On 2019/03/19 20:13, Imai, Yoshikazu wrote:
> Thanks for new patches.
> I looked over them and there are little comments.
>
> [0002]
> * s/regresion/regression/g
> (in commit message.)
>
> [0003]
> * I thought "inh flag is it" is "inh flag is set" ...?
>
> + * For RTE_RELATION rangetable entries whose inh flag is it, adjust the
>
>
> * Below comments are correct when after applying 0004.
>
> + * the query's target relation and no other. Especially, children of any
> + * source relations are added when the loop below calls grouping_planner
> + * on the *1st* child target relation.
>
> [0004]
> * s/contain contain/contain/
>
> + * will contain contain references to the subquery RTEs that we've
>
>
> * s/find them children/find their children/
>
> + * AppendRelInfos needed to find them children, so the next
>
> [0006]
> * s/recursivly/recursively/
> (in commit message)
>
>
> I have no more comments about codes other than above :)

I have fixed all. Attached updated patches.

Thanks,
Amit