| From: | Ryoga Yoshida <bt23yoshidar(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Aleksander Alekseev <aleksander(at)timescale(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Subject: | Re: Bug fix for psql's meta-command \ev |
| Date: | 2023-09-20 05:08:34 |
| Message-ID: | 0b87efc5a628fe4f1144c2d6879894dc@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2023-09-20 09:32, Michael Paquier wrote:
> Actually there was a bit more to it in the presence of \e, that could
> also get some unpredictible behaviors if some errors happen while
> editing a query, which is something unlikely, still leads to strange
> behaviors on failure injections. I was considering first to move the
> reset in do_edit(), but also we have the case of \e[v|f] where the
> buffer has no edits so it felt a bit more natural to do that in the
> upper layer like in this patch.
Indeed, similar behaviours can happen with the \e. The patch you
committed looks good to me. Thank you.
Ryoga Yoshida
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2023-09-20 05:18:41 | Re: pg_ctl start may return 0 even if the postmaster has been already started on Windows |
| Previous Message | Michael Paquier | 2023-09-20 05:06:25 | Re: XLog size reductions: Reduced XLog record header size for PG17 |