Re: Change copyObject() to use typeof_unqual

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Change copyObject() to use typeof_unqual
Date: 2026-03-17 15:53:28
Message-ID: 0b2c3f99-b27a-4921-9271-33ab1bd231a3@eisentraut.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 17.03.26 11:56, Jelte Fennema-Nio wrote:
> On Tue Mar 17, 2026 at 3:39 AM CET, Tom Lane wrote:
>> While this version of clang doesn't like typeof_unqual, it does take
>> __typeof_unqual__.  So maybe we were premature to decide that we
>> could prefer the typeof_unqual spelling.
>
> Hmmm, that makes sense. How about this patch to at least keep the
> all the logic related to this in one place? I was able to reproduce this
> error using the following flags, and this fixes the issue for me.
>
> CC=clang-21 CXX=clang++-21 CFLAGS=-std=c23 BITCODE_CFLAGS=-std=gnu17
> CLANG=clang-19 LLVM_CONFIG=llvm-config-19

committed

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2026-03-17 16:06:27 Re: Why clearing the VM doesn't require registering vm buffer in wal record
Previous Message Greg Burd 2026-03-17 15:52:30 Re: Expanding HOT updates for expression and partial indexes