Re: [PATCH] Accept IP addresses in server certificate SANs

From: Jacob Champion <pchampion(at)vmware(dot)com>
To: "horikyota(dot)ntt(at)gmail(dot)com" <horikyota(dot)ntt(at)gmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Accept IP addresses in server certificate SANs
Date: 2022-01-04 22:58:14
Message-ID: 0af96f12e4b2f5352e69139f89a63ce5f2184104.camel@vmware.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 2021-12-16 at 18:44 +0000, Jacob Champion wrote:
> It sounds like both you and Andrew might be comfortable with that same
> behavior? I think it looks like a sane solution, so I'll implement that
> and we can see what it looks like. (My work on this will be paused over
> the end-of-year holidays.)

v2 implements the discussed CN/SAN fallback behavior and should fix the
build on Windows. Still TODO is the internal pg_inet_pton() refactoring
that you asked for; I'm still deciding how best to approach it.

Changes only in since-v1.diff.txt.

Thanks,
--Jacob

Attachment Content-Type Size
since-v1.diff.txt text/plain 22.1 KB
v2-0001-Move-inet_net_pton-to-src-port.patch text/x-patch 4.5 KB
v2-0002-libpq-allow-IP-address-SANs-in-server-certs.patch text/x-patch 38.2 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-01-04 23:02:43 Re: pg_stat_statements and "IN" conditions
Previous Message Tom Lane 2022-01-04 22:30:59 Re: Consider parallel for lateral subqueries with limit