Re: [Proposal] Allow users to specify multiple tables in VACUUM commands

From: "Bossart, Nathan" <bossartn(at)amazon(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Subject: Re: [Proposal] Allow users to specify multiple tables in VACUUM commands
Date: 2017-08-31 01:52:13
Message-ID: 0D80301E-E756-4DD4-8073-CA872903E9D6@amazon.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 8/30/17, 5:37 PM, "Michael Paquier" <michael(dot)paquier(at)gmail(dot)com> wrote:
> +VacuumRelation *
> +makeVacuumRelation(RangeVar *relation, List *va_cols, Oid oid)
> +{
> + VacuumRelation *vacrel = makeNode(VacuumRelation);
> + vacrel->relation = relation;
> + vacrel->va_cols = va_cols;
> + vacrel->oid = oid;
> + return vacrel;
> +}
> Perhaps in makefuncs.c instead of vacuum.c? That's usually the place
> used for node constructions like that.

This function is moved in v11.

On 8/30/17, 6:52 PM, "Michael Paquier" <michael(dot)paquier(at)gmail(dot)com> wrote:
> On Thu, Aug 31, 2017 at 8:35 AM, David G. Johnston
> <david(dot)g(dot)johnston(at)gmail(dot)com> wrote:
>> Inspired by the syntax documentation for EXPLAIN:
>>
>> VACUUM [ ( option [, ...] ) ] [ table_def [, ...] ]
>>
>> where option can be one of:
>> FULL
>> FREEZE
>> VERBOSE
>> DISABLE_PAGE_SKIPPING
>>
>> and where table_def is:
>> table_name [ ( column_name [, ... ] ) ]
>
> Yes, splitting things would be nice with the column list. I need more coffee.

I've made this change in v11 as well.

v2 of the de-duplication patch seems to still apply cleanly, so I haven't
made any further changes to it.

Nathan

Attachment Content-Type Size
dedupe_vacuum_relations_v2.patch application/octet-stream 4.7 KB
vacuum_multiple_tables_v11.patch application/octet-stream 31.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tatsuro Yamada 2017-08-31 02:12:02 CLUSTER command progress monitor
Previous Message Masahiko Sawada 2017-08-31 01:42:04 Re: pgbench: Skipping the creating primary keys after initialization