Re: [Proposal] Allow users to specify multiple tables in VACUUM commands

From: "Bossart, Nathan" <bossartn(at)amazon(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: [Proposal] Allow users to specify multiple tables in VACUUM commands
Date: 2017-09-04 14:47:09
Message-ID: 0C672836-1D86-4909-A730-E7D2DB48E179@amazon.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 9/4/17, 7:14 AM, "Bossart, Nathan" <bossartn(at)amazon(dot)com> wrote:
> On 9/3/17, 11:46 PM, "Michael Paquier" <michael(dot)paquier(at)gmail(dot)com> wrote:
>> I did not consider first that the list portion also needed to be
>> modified, perhaps because I am not coding that myself... So now that
>> it is becoming more complicated what about just using AutovacMemCxt?
>> This would simplify the list of VacuumRelation entries and the
>> RangeVar creation as well, and honestly this is ugly and there are no
>> other similar patterns in the backend code:
>
> +1

I've made this change in v14 of the main patch.

In case others had opinions regarding the de-duplication patch, I've
attached that again as well.

Nathan

Attachment Content-Type Size
dedupe_vacuum_relations_v3.patch application/octet-stream 4.7 KB
vacuum_multiple_tables_v14.patch application/octet-stream 31.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2017-09-04 15:20:58 Re: GnuTLS support
Previous Message Arseny Sher 2017-09-04 14:43:09 Re: DROP SUBSCRIPTION hangs if sub is disabled in the same transaction