RE: Re: reloption to prevent VACUUM from truncating empty pages at the end of relation

From: "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>
To: 'Julien Rouhaud' <rjuju123(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Andrew Dunstan" <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "Laurenz Albe" <laurenz(dot)albe(at)cybertec(dot)at>, "Jamison, Kirk" <k(dot)jamison(at)jp(dot)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: RE: Re: reloption to prevent VACUUM from truncating empty pages at the end of relation
Date: 2019-04-05 01:14:47
Message-ID: 0A3221C70F24FB45833433255569204D1FBEFCEE@G01JPEXMBYT05
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

From: Masahiko Sawada [mailto:sawada(dot)mshk(at)gmail(dot)com]
> "VACUUM" needs <command> or "vacuum" is more appropriate here?

Looking at the same file and some other files, "vacuum" looks appropriate because it represents the vacuum action, not the specific VACUUM command.

> The format of the documentation of new option is a bit weird. Could it
> be possible to adjust it around 80 characters per line like other
> description?

Ah, fixed. It's easy to overlook the style with the screen reader software... I've been wondering if there are good settings for editing .sgml in Emacs that, for example, puts appropriate number of spaces at the beginning of each line when <Tab> is pressed, automatically break the long line and put spaces, etc.

From: Julien Rouhaud [mailto:rjuju123(at)gmail(dot)com]
> also, the documentation should point out that freeing is not
> guaranteed. Something like
> + The default is true. If true, VACUUM will try to free empty
> pages at the end of the table.

That's nice. Done.

> > I'm not sure the consensus we got here but we don't make the vacuum
> > command option for this?
> I don't think here's a clear consensus, but my personal vote is to add
> it, with SHRINK_TABLE = [ force_on | force_off | default ] (unless a
> better proposal has been made already)

IMO, which I mentioned earlier, I don't think the VACUUM option is necessary because:
(1) this is a table property which is determined based on the expected workload, not the one that people want to change per VACUUM operation
(2) if someone wants to change the behavior for a particular VACUUM operation, he can do it using ALTER TABLE SET.
Anyway, we can add the VACUUM option separately if we want it by all means. I don't it to be the blocker for this feature to be included in PG 12, because the vacuum truncaton has been bothering us like others said in this and other threads...

Takayuki Tsunakawa

Attachment Content-Type Size
disable-vacuum-truncation_v6.patch application/octet-stream 8.9 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2019-04-05 01:14:50 Re: Re: reloption to prevent VACUUM from truncating empty pages at the end of relation
Previous Message Andres Freund 2019-04-05 00:44:34 Re: COPY FROM WHEN condition