| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)2ndquadrant(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Improper use about DatumGetInt32 |
| Date: | 2021-01-13 08:27:37 |
| Message-ID: | 09e2dd82-4eb6-bba1-271a-d2b58bf6c71f@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-01-11 09:09, Michael Paquier wrote:
> On Sat, Jan 09, 2021 at 01:41:39PM +0100, Peter Eisentraut wrote:
>> If we had a way to do such testing then we wouldn't need these markers. But
>> AFAICT, we don't.
>
> Not sure I am following your point here. Taking your patch, it is
> possible to trigger the version of get_raw_page() <= 1.8 just with
> something like the following:
> create extension pageinspect version "1.8";
> select get_raw_page('pg_class', 0);
>
> There are no in-core regression tests that check the compatibility of
> extensions with older versions, but it is technically possible to do
> so.
Interesting idea. Here is a patch that incorporates that.
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-pageinspect-Change-block-number-arguments-to-bigi.patch | text/plain | 21.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ajin Cherian | 2021-01-13 08:33:12 | Re: Track replica origin progress for Rollback Prepared |
| Previous Message | Michael Paquier | 2021-01-13 08:22:49 | Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly |