|From:||Daniel Gustafsson <daniel(at)yesql(dot)se>|
|To:||Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>|
|Subject:||Re: Error detail/hint style fixup|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
> On 19 Mar 2018, at 17:47, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>> Attached patch ensures that (i) details and hints have leading capitalization,
>> have double spaces after punctuation and ends with period; (ii) context should
>> not be capitalized and should not end with period; (iii) test .out files match
>> the changes.
> +1 for cleaning this up, but I wonder if you've gone far enough in
> adjusting the style of errcontext() messages.
Thanks for looking/reviewing.
> I'm thinking what we should actually be printing is more like
> CONTEXT: while opening cursor on dblink connection named “unnamed"
I agree that the contexts in dblink were pretty unhelpful with redundant
language. I took a stab at this, the attached patch extends dblink_res_error()
to improve the context. Including the cursorname in the context seemed to be
in line with the errmsg’s in dblink.
Looking around at other errcontext’s I can’t see any other cases that warrant
|Next Message||Peter Geoghegan||2018-03-19 21:12:29||Re: found xmin from before relfrozenxid on pg_catalog.pg_authid|
|Previous Message||Jeremy Finzel||2018-03-19 20:55:44||Re: found xmin from before relfrozenxid on pg_catalog.pg_authid|