| From: | Masahiro Ikeda <ikedamsh(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Tristan Partin <tristan(at)neon(dot)tech>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Support to define custom wait events for extensions |
| Date: | 2023-08-09 11:10:42 |
| Message-ID: | 0850ea2f23217b3a87340dd2d721d051@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Thanks for your comments to v1 patch.
I made v2 patch. Main changes are
* change to NAMEDATALEN
* change to use dynahash from dshash
* remove worker_spi_init()
* create second hash table to find a event id from a name to
identify uniquness. It enable extensions which don't use share
memory for their use to define custom wait events because
WaitEventExtensionNew() will not allocate duplicate wait events.
* create PoC patch to show that extensions, which don't use shared
memory for their use, can define custom wait events.
(v2-0002-poc-custom-wait-event-for-dblink.patch)
I'm worrying about
* Is 512(wee_hash_max_size) the maximum number of the custom wait
events sufficient?
* Is there any way to not force extensions that don't use shared
memory for their use like dblink to acquire AddinShmemInitLock?;
Regards,
--
Masahiro Ikeda
NTT DATA CORPORATION
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Change-to-manage-custom-wait-events-in-shared-hash.patch | text/x-diff | 18.2 KB |
| v2-0002-poc-custom-wait-event-for-dblink.patch | text/x-diff | 1.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alena Rybakina | 2023-08-09 11:33:31 | Re: POC, WIP: OR-clause support for indexes |
| Previous Message | Alvaro Herrera | 2023-08-09 11:10:29 | Re: cataloguing NOT NULL constraints |