Re: Logical Replication WIP

On 31/10/16 00:52, Steve Singer wrote:
> On 10/24/2016 09:22 AM, Petr Jelinek wrote:
>> Hi,
>>
>> attached is updated version of the patch.
>>
>> There are quite a few improvements and restructuring, I fixed all the
>> bugs and basically everything that came up from the reviews and was
>> agreed on. There are still couple of things missing, ie column type
>> definition in protocol and some things related to existing data copy.
>
> Here are a few things I've noticed so far.
>
> +<programlisting>
> +CREATE SUBSCRIPTION mysub WITH CONNECTION <quote>dbname=foo host=bar
> user=repuser</quote> PUBLICATION mypub;
> +</programlisting>
> + </para>
> + <para>
>
> The documentation above doesn't match the syntax, CONNECTION needs to be
> in single quotes not double quotes
> I think you want
> +<programlisting>
> +CREATE SUBSCRIPTION mysub WITH CONNECTION 'dbname=foo host=bar
> user=repuser' PUBLICATION mypub;
> +</programlisting>
> + </para>
> + <para>
>

Yes.

>
> I am not sure if this is a known issue covered by your comments about
> data copy but I am still having issues with error reporting on a failed
> subscription.
>
> I created a subscription, dropped the subscription and created a second
> one. The second subscription isn't active but shows no errors.
>

There are some fundamental issues with initial sync that need to be
discussed on list but this one is not known. I'll try to convert this to
test case (seems like useful one) and fix it, thanks for the report.

In meantime I realized I broke the last patch in the series during
rebase so attached is the fixed version. It also contains the type info
in the protocol.

--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services