| From: | "Daniel Verite" <daniel(at)manitou-mail(dot)org> |
|---|---|
| To: | "Rahila Syed" <rahilasyed90(at)gmail(dot)com> |
| Cc: | "Stephen Frost" <sfrost(at)snowman(dot)net>,"Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>,"Ashutosh Bapat" <ashutosh(dot)bapat(at)enterprisedb(dot)com>,"pgsql-hackers" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Improvements in psql hooks for variables |
| Date: | 2016-12-23 21:54:14 |
| Message-ID: | 070e0223-6b73-43e1-bf89-d277cf51fefe@manitou-mail.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Rahila Syed wrote:
> Kindly consider following comments,
Sorry for taking so long to post an update.
> There should not be an option to the caller to not follow the behaviour of
> setting valid to either true/false.
OK, fixed.
> In following examples, incorrect error message is begin displayed.
> “ON_ERROR_ROLLBACK” is an enum and also
> accepts value 'interactive' . The error message says boolean expected.
Indeed. Fixed for all callers of ParseVariableBool() than can accept
non-boolean arguments too.
Best regards,
--
Daniel Vérité
PostgreSQL-powered mailer: http://www.manitou-mail.org
Twitter: @DanielVerite
| Attachment | Content-Type | Size |
|---|---|---|
| psql-var-hooks-v6.patch | text/plain | 15.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-12-23 22:16:57 | Re: propose to pushdown qual into EXCEPT |
| Previous Message | David Steele | 2016-12-23 21:02:12 | Re: Remove lower limit on checkpoint_timeout? |