| From: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
|---|---|
| To: | David Steele <david(at)pgmasters(dot)net>, Euler Taveira <euler(at)eulerto(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Stephen Frost <sfrost(at)snowman(dot)net>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, SATYANARAYANA NARLAPURAM <satyanarlapuram(at)gmail(dot)com> |
| Subject: | Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file |
| Date: | 2022-01-07 18:17:29 |
| Message-ID: | 03CFDCC3-823F-41E0-BCF1-E5B1F11DEADD@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 1/7/22, 5:52 AM, "David Steele" <david(at)pgmasters(dot)net> wrote:
> On 1/6/22 20:20, Euler Taveira wrote:
>> On Thu, Jan 6, 2022, at 9:48 PM, Bossart, Nathan wrote:
>>> After a quick glance, I didn't see an easy way to hold a session open
>>> while the test does other things. If there isn't one, modifying
>>> backup_fs_hot() to work with non-exclusive mode might be more trouble
>>> than it is worth.
>>
>> You can use IPC::Run to start psql in background. See examples in
>> src/test/recovery.
>
> I don't think updating backup_fs_hot() is worth it here.
>
> backup_fs_cold() works just fine for this case and if there is a need
> for backup_fs_hot() in the future it can be implemented as needed.
Thanks for the pointer on IPC::Run. I had a feeling I was missing
something obvious!
I think I agree with David that it still isn't worth it for just this
one test. Of course, it would be great to test the non-exclusive
backup logic as much as possible, but I'm not sure that this
particular test will provide any sort of meaningful coverage.
Nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bossart, Nathan | 2022-01-07 18:23:24 | Re: Disallow quorum uncommitted (with synchronous standbys) txns in logical replication subscribers |
| Previous Message | Bossart, Nathan | 2022-01-07 18:09:23 | Re: make MaxBackends available in _PG_init |