RE: SQL statement PREPARE does not work in ECPG

From: "Matsumura, Ryo" <matsumura(dot)ryo(at)jp(dot)fujitsu(dot)com>
To: 'Michael Meskes' <meskes(at)postgresql(dot)org>, "Takahashi, Ryohei" <r(dot)takahashi_2(at)fujitsu(dot)com>, "'pgsql-hackers(at)postgresql(dot)org'" <pgsql-hackers(at)postgresql(dot)org>
Cc: "Ideriha, Takeshi" <ideriha(dot)takeshi(at)jp(dot)fujitsu(dot)com>, "Kuroda, Hayato" <kuroda(dot)hayato(at)fujitsu(dot)com>
Subject: RE: SQL statement PREPARE does not work in ECPG
Date: 2019-05-31 06:55:19
Message-ID: 03040DFF97E6E54E88D3BFEE5F5480F74ABEADE7@G01JPEXMBYT04
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Meskes-san

> This looks good to me. It passes all my tests, too.
>
> There were two minor issues, the regression test did not run and gcc
> complained about the indentation in ECPGprepare(). Both I easily fixed.

Thank you so much !

> > (2)
> > I found some bugs (two types). I didn't fix them and only avoid bison
> > error.
> >
> > Type1. Bugs or intentional unsupported features.
> > - EXPLAIN EXECUTE
> > - CREATE TABLE AS with using clause
> > ...
>
> Please send a patch. I'm on vacation and won't be able to spend time on
> this for the next couple of weeks.

I begin to fix it. It may spend a while (1 or 2 week).

> > Type2. In multi-bytes encoding environment, a part of character of
> > message is cut off.
> >
> > It may be very difficult to fix. I pretend I didn't see it for a
> > while.
> > ...
>
> Hmm, any suggestion?

I think that it's better to import length_in_encoding() defined in backend/utils/mb/mbutils.c into client side.
Just an idea.

Regards
Ryo Matsumura

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Antonin Houska 2019-05-31 06:59:41 Re: "WIP: Data at rest encryption" patch and, PostgreSQL 11-beta3
Previous Message Donald Shtjefni 2019-05-31 06:35:31 Time range