| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Shinya Kato <shinya11(dot)kato(at)gmail(dot)com>, Kirill Reshke <reshkekirill(at)gmail(dot)com> |
| Cc: | Japin Li <japinli(at)hotmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: remove unnecessary include in src/backend/commands/policy.c |
| Date: | 2026-02-24 10:50:35 |
| Message-ID: | 02d48c6a-1279-47a8-9154-f88c98067a90@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12.02.26 03:05, Shinya Kato wrote:
> On Sun, Jan 4, 2026 at 4:47 AM Kirill Reshke <reshkekirill(at)gmail(dot)com> wrote:
>> We also can reflect that our new coding practice is to use table/index
>> open over relation_open in the commit message (I guess so after[0]).
>
> Thanks for the review. I've updated the commit message.
I don't understand the point of this patch. It changes some
relation_open() calls to table_open(). The only difference of
table_open() is that it checks the relkind. But in these cases, the
relkind was already checked earlier via RangeVarCallbackForPolicy. So
this change has no effect, but it adds extra overhead.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ajin Cherian | 2026-02-24 11:04:26 | Re: [PATCH] Support automatic sequence replication |
| Previous Message | David Geier | 2026-02-24 10:43:15 | Cleaning up array_ref() and array_set() |