Re: Implement <null treatment> for window functions

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Vik Fearing <vik(at)postgresfriends(dot)org>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Implement <null treatment> for window functions
Date: 2020-07-01 12:27:45
Message-ID: 02B860B7-E72B-4EF0-8C70-2FC36DD94D80@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 30 Jun 2020, at 15:54, Vik Fearing <vik(at)postgresfriends(dot)org> wrote:

> This feature adds RESPECT NULLS and IGNORE NULLS syntax to several
> window functions, according to the SQL Standard.

This fails compilation due to a compiler warning in WinGetFuncArgInPartition
and WinGetFuncArgInFrame (same warning in both):

nodeWindowAgg.c: In function ‘WinGetFuncArgInPartition’:
nodeWindowAgg.c:3274:10: error: ‘step’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
relpos += step;
^
This was with GCC in the Travis build, the Windows build passed and so does
clang locally for me.

cheers ./daniel

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2020-07-01 12:34:31 Re: Make MemoryContextMemAllocated() more precise
Previous Message Daniel Gustafsson 2020-07-01 12:15:54 Re: Identifying user-created objects