Re: pg_upgrade fails with non-standard ACL

From: Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>
To: Bruce Momjian <bruce(at)momjian(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pg_upgrade fails with non-standard ACL
Date: 2019-10-04 11:53:40
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

27.09.2019 15:51, Bruce Momjian wrote:
> On Fri, Sep 27, 2019 at 04:22:15PM +0900, Michael Paquier wrote:
>> On Thu, Sep 26, 2019 at 04:19:38PM -0400, Bruce Momjian wrote:
>>> On Thu, Sep 26, 2019 at 05:16:19PM -0300, Alvaro Herrera wrote:
>>>> On 2019-Sep-26, Bruce Momjian wrote:
>>>>> Well, right now, pg_upgrade --check succeeds, but the upgrade fails. I
>>>>> am proposing, at a minimum, that pg_upgrade --check fails in such cases,
>>>> Agreed, that should be a minimum fix.
>>> Yes.
>> Agreed as well here. At least the latest patch proposed has the merit
>> to track automatically functions not existing anymore from the
>> source's version to the target's version, so patching --check offers a
>> good compromise. Bruce, are you planning to look more at the patch
>> posted at [1]?
> I did look at it. It has some TODO items listed in it still, and some
> C++ comments, but if everyone likes it I can apply it.

Cool. It seems that everyone agrees on this patch.

I attached the updated version. Now it prints a better error message
and generates an SQL script instead of multiple warnings. The attached
test script shows that.

Patches for 10, 11, and 12 slightly differ due to merge conflicts, so I
attached multiple versions.

Anastasia Lubennikova
Postgres Professional:
The Russian Postgres Company

Attachment Content-Type Size
pg_upgrade_ACL_check_v2_REL10.patch text/x-patch 8.0 KB
pg_upgrade_ACL_check_v2_REL11.patch text/x-patch 8.0 KB
pg_upgrade_ACL_check_v2_REL12.patch text/x-patch 8.0 KB application/x-shellscript 3.2 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2019-10-04 11:55:15 Re: [HACKERS] Block level parallel vacuum
Previous Message Natarajan R 2019-10-04 11:36:47 HashTable KeySize