Re: [pgadmin-support] pgAdmin III Query Tool bug

From: "Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>
To: "Dave Page" <dpage(at)postgresql(dot)org>, "Andrew" <archa(at)pacific(dot)net(dot)au>
Cc: <pgadmin-support(at)postgresql(dot)org>, <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgadmin-support] pgAdmin III Query Tool bug
Date: 2008-01-09 04:45:20
Message-ID: 011e01c8527a$75704980$c601a8c0@HP22720319231
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers pgadmin-support

Hi Dave.

Yeah, we know the user who had the same problem in the past. However, In Japan,
it needed to be written by encoding of a client, and We did not want to set an initial
value to UTF-8. Therefore, It is need recognized by the warning message.
How is an attached patch proposal?

Regards,
Hiroshi Saito

----- Original Message -----
From: "Dave Page" <dpage(at)postgresql(dot)org>

> On 08/01/2008, Andrew <archa(at)pacific(dot)net(dot)au> wrote:
>> Excellent,
>>
>> Thanks Hiroshi Saito, that worked a treat, I really appreciate you
>> posting those images. Apologies for taking up your time for something I
>> probably could have figured out by RTFM.
>
> Yes, thanks Hiroshi (our resident encoding guru :-) ).
>
>> However, IMHO I still think it is a defect, in that it shouldn't really
>> be saving a 0 byte file silently, when you think it has successfully
>> saved your changes, and then when you go back to the file you find the
>> data you have worked on is lost. If it is in a mode not to support the
>> characters, then it should alert you that it cannot save those
>> characters. However, I will leave that for the development team to
>> decide if it is defective behaviour or behaviour by design.
>
> Absolutely agree. Hiroshi; we do something similar in frmExport:
>
> if (rbUnicode->GetValue())
> file.Write(line, wxConvUTF8);
> else
> {
> buf = line.mb_str(wxConvLibc);
> if (!buf)
> skipped++;
> else
> file.Write(line, wxConvLibc);
> }
>
> (we then warn the user if skipped > 0). Would something similar
> suffice do you think?
>
> /D

Attachment Content-Type Size
Query_patch.txt text/plain 2.5 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2008-01-09 09:32:10 Re: [pgadmin-support] pgAdmin III Query Tool bug
Previous Message svn 2008-01-08 16:53:15 SVN Commit by dpage: r6984 - in branches/REL-1_8_0_PATCHES/pgadmin3: . pgadmin/dlg pgadmin/schema

Browse pgadmin-support by date

  From Date Subject
Next Message Dave Page 2008-01-09 09:32:10 Re: [pgadmin-support] pgAdmin III Query Tool bug
Previous Message Thomas H. 2008-01-09 03:43:28 bug: the schema oid can't be located, please refresh all schemas