| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Euler Taveira <euler(dot)taveira(at)2ndquadrant(dot)com> |
| Cc: | Quan Zongliang <quanzongliang(at)foxmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Restore replication settings when modifying a field type |
| Date: | 2020-03-13 12:32:27 |
| Message-ID: | 01068a4d-e810-cd73-10db-6b4660b9e6b9@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-03-10 14:16, Euler Taveira wrote:
> On Thu, 5 Mar 2020 at 09:45, Peter Eisentraut
> <peter(dot)eisentraut(at)2ndquadrant(dot)com
> <mailto:peter(dot)eisentraut(at)2ndquadrant(dot)com>> wrote:
>
> On 2020-02-11 00:38, Quan Zongliang wrote:
> > new patch attached.
>
> I didn't like so much how the updating of the replica identity was
> hacked into the middle of ATRewriteCatalogs(). I have an alternative
> proposal in the attached patch that queues up an ALTER TABLE ...
> REPLICA
> IDENTITY command into the normal ALTER TABLE processing. I have also
> added tests to the test suite.
>
> LGTM. Tests are ok. I've rebased it (because
> 61d7c7bce3686ec02bd64abac742dd35ed9b9b01). Are you planning to backpatch
> it? IMHO you should because it is a bug (since REPLICA IDENTITY was
> introduced in 9.4). This patch can be applied as-is in 12 but not to
> other older branches. I attached new patches.
Thanks. This has been committed and backpatched to 9.5.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | tushar | 2020-03-13 12:40:42 | Re: [Proposal] Global temporary tables |
| Previous Message | Hugh McMaster | 2020-03-13 12:26:03 | Re: [PATCH] Use PKG_CHECK_MODULES to detect the libxml2 library |