Re: [PATCH] Proposal for HIDDEN/INVISIBLE column

Le 27/10/2021 à 17:47, Erik Rijkers a écrit :
> Op 27-10-2021 om 16:33 schreef Gilles Darold:
>>>
>>> - Fix documentation about some sgml tag broken.
>>>
>>>
>>> About ROWTYPE generating an error when SELECT * INTO or RETURNING *
>>> INTO
>>> is used with unexpanded column, I have kept things like that because it
>>> is the normal behavior. I have checked on others database engine and
>>> this is the same.1
>>
>>
>> And finally I found the reason of the diff on compression.out and
>> collate.linux.utf8.out, new version v5 of the patch attached.
>>
> > [ 0001-hidden-column-v5.patch ]
>
>
> This warning during compile from gcc 11.2:
>
> pg_dump.c: In function ‘dumpTableSchema’:
> pg_dump.c:16327:56: warning: comparison of constant ‘0’ with boolean
> expression is always true [-Wbool-compare]
> 16327 |                         if (tbinfo->attisunexpanded[j] >= 0)
>       |                                                        ^~
>
> Otherwise, build, make check, chekc-world are OK.  Also the pdf builds
> ok.
>
> Thanks,
>
> Erik Rijkers

Thanks Erik, new version v6 attached.

--
Gilles Darold