| From: | Alex <ash(at)commandprompt(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Another review of URI for libpq, v7 submission |
| Date: | 2012-03-27 22:49:40 |
| Message-ID: | 87pqbxk6bf.fsf@commandprompt.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alex <ash(at)commandprompt(dot)com> writes:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>>
>> Attached is a patch on top of your v9 with two small fixes:
>>
>> - Don't provide a check target in libpq/Makefile if it's not
>> implemented.
>>
>> - Use the configured port number for running the tests (otherwise it
>> runs against my system installation, for example).
>
> Neat, thank you.
Attached is a gzipped v10, complete with the above fixes and fixes to
bugs found by Heikki. Documentation and code comments are also finally
updated.
Of all the command-line utilities which can accept conninfo string, only
psql mentions that, so only its documentation was updated. Other
utilities, like pg_dump and pg_restore can also work with either
conninfo or URI, however this remains undocumented.
--
Alex
| Attachment | Content-Type | Size |
|---|---|---|
| libpq-uri-v10.patch.gz | application/octet-stream | 10.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Farina | 2012-03-27 22:52:04 | Re: Cross-backend signals and administration (Was: Re: pg_terminate_backend for same-role) |
| Previous Message | Tom Lane | 2012-03-27 21:05:30 | Re: Re: pg_stat_statements normalisation without invasive changes to the parser (was: Next steps on pg_stat_statements normalisation) |