Re: BUG #12779: pg_dump -Fd doesn't care about -Z

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: christoph(dot)berg(at)credativ(dot)de, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #12779: pg_dump -Fd doesn't care about -Z
Date: 2015-02-18 05:59:17
Message-ID: CAB7nPqTLSv5qES=9hODzkX62V5XcivP1ij=_iahR_-SriD2AOA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Wed, Feb 18, 2015 at 3:52 AM, Tom Lane wrote:
> This doesn't look tremendously hard to fix, but it's not a one-liner
> either. Don't have time for it personally right now.

Interesting. The call to gzopen is missing the compression level,
always passing either 'w' or 'wb', while for example to write with a
compression level of 6 we should pass w6 or wb6.

The patch attached addresses that.
--
Michael

Attachment Content-Type Size
20150218_pgdump_gzopen_fix.patch application/x-patch 1.4 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Christoph Berg 2015-02-18 09:17:12 Re: BUG #12779: pg_dump -Fd doesn't care about -Z
Previous Message Tom Lane 2015-02-17 18:52:01 Re: BUG #12779: pg_dump -Fd doesn't care about -Z