Re: BUG #12779: pg_dump -Fd doesn't care about -Z

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: christoph(dot)berg(at)credativ(dot)de, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #12779: pg_dump -Fd doesn't care about -Z
Date: 2015-02-18 16:45:13
Message-ID: 11740.1424277913@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> On Wed, Feb 18, 2015 at 3:52 AM, Tom Lane wrote:
>> This doesn't look tremendously hard to fix, but it's not a one-liner
>> either. Don't have time for it personally right now.

> Interesting. The call to gzopen is missing the compression level,
> always passing either 'w' or 'wb', while for example to write with a
> compression level of 6 we should pass w6 or wb6.

> The patch attached addresses that.

Committed. I also fixed another problem in this code, which was an
overoptimistic assumption that free() doesn't change errno; we've heard
that it can on OS X at least. That would've resulted in faulty error
reports for file-open failures.

regards, tom lane

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2015-02-18 16:54:57 Re: BUG #12782: Some abnormal observation about the to_date() function in greenplum database
Previous Message patl659in 2015-02-18 15:45:51 BUG #12782: Some abnormal observation about the to_date() function in greenplum database