From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | christoph(dot)berg(at)credativ(dot)de |
Cc: | pgsql-bugs(at)postgresql(dot)org |
Subject: | Re: BUG #12779: pg_dump -Fd doesn't care about -Z |
Date: | 2015-02-17 18:52:01 |
Message-ID: | 21598.1424199121@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
christoph(dot)berg(at)credativ(dot)de writes:
> pg_dump -Fd doesn't seem to care about -Z for Z > 0:
Yeah, you're right: whoever wrote pg_dump/compress_io.c seems to have
been utterly clueless about the idea that zlib needs to be told which
compression level to use. That logic is just treating the compression
level as a binary compress-or-not flag. cfopen_write() is obviously
losing the compression level info, and even if it weren't, cfopen()
thinks that argument is binary not a number to pass down. There may be
other subroutines in there and/or in pg_backup_directory.c that missed
the memo as well.
This doesn't look tremendously hard to fix, but it's not a one-liner
either. Don't have time for it personally right now.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2015-02-18 05:59:17 | Re: BUG #12779: pg_dump -Fd doesn't care about -Z |
Previous Message | Tom Lane | 2015-02-17 18:28:40 | Re: Fwd: BUG #12772: Unexpected autovacuum behavior |