Re: [patch] Potential relcache leak in get_object_address_attribute

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Marti Raudsepp <marti(at)juffo(dot)org>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [patch] Potential relcache leak in get_object_address_attribute
Date: 2014-01-21 15:03:28
Message-ID: CA+TgmoZdBvYrVMX0PuGFmGQ8jhjUEgDfaM0DSD3MfUjdWiCK8g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jan 18, 2014 at 7:14 PM, Marti Raudsepp <marti(at)juffo(dot)org> wrote:
> It looks like the get_object_address_attribute() function has a
> potential relcache leak. When missing_ok=true, the relation is found
> but attribute is not, then the relation isn't closed, nor is it
> returned to the caller.
>
> I couldn't figure out any ways to trigger this, but it's best to fix anyway.

I agree. Committed, thanks for the patch.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2014-01-21 15:11:23 Re: Add %z support to elog/ereport?
Previous Message Robert Haas 2014-01-21 14:55:06 Re: Why conf.d should be default, and auto.conf and recovery.conf should be in it