| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Josh Berkus <josh(at)agliodbs(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Why conf.d should be default, and auto.conf and recovery.conf should be in it |
| Date: | 2014-01-21 14:55:06 |
| Message-ID: | CA+TgmoadsUVCHAgetqrOAG6jc4P9VovCu7WM5NABf1SkMyGSKA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 17, 2014 at 12:07 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Fri, Jan 17, 2014 at 12:16 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> PS: off topic, but isn't ParseConfigDirectory leaking the result
>> of AbsoluteConfigLocation? In both normal and error paths?
>
> Yes, I also think it leaks in both cases and similar leak is
> present in ParseConfigFile(). I have tried to fix both of these
> leaks with attached patch.
Committed and back-patched to 9.3. While reviewing, I noted that the
"skipping missing configuration file" message in ParseConfigFile()
uses an elevel of LOG, while the other messages in the same file use
"elevel". I'm thinking that's a bug.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2014-01-21 15:03:28 | Re: [patch] Potential relcache leak in get_object_address_attribute |
| Previous Message | Rohit Goyal | 2014-01-21 14:52:30 | Request for error explaination || Adding a new integer in indextupleData Structure |