[patch] Potential relcache leak in get_object_address_attribute

From: Marti Raudsepp <marti(at)juffo(dot)org>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: [patch] Potential relcache leak in get_object_address_attribute
Date: 2014-01-19 00:14:32
Message-ID: CABRT9RDdFVc05vhQCZ7QR_B-_cbQZOGv=oehepuYAt_LGrV4PA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi list,

It looks like the get_object_address_attribute() function has a
potential relcache leak. When missing_ok=true, the relation is found
but attribute is not, then the relation isn't closed, nor is it
returned to the caller.

I couldn't figure out any ways to trigger this, but it's best to fix anyway.

Regards,
Marti

Attachment Content-Type Size
objectaddress_relcache_leak.patch text/x-patch 470 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2014-01-19 00:29:37 Re: Heavily modified big table bloat even in auto vacuum is running
Previous Message Stephen Frost 2014-01-19 00:11:20 pgsql: Add ALTER TABLESPACE ... MOVE command