Re: HAVE_FSEEKO for WIN32

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: HAVE_FSEEKO for WIN32
Date: 2009-01-07 10:11:26
Message-ID: 49647FCE.6010204@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian wrote:
> Andrew Dunstan wrote:
>> Cleaning up the parallel restore patch I came across a question I might
>> have asked before, but one which in any case I worked around:
>>
>> Why do we carefully define fseeko() for WIN32 but then not define
>> HAVE_FSEEKO, which makes doing the former pretty much pointless?
>
> With Andrew, I have developed and applied the attached patch so MinGW
> handles fseeko() translation similar to Unix.
>
> Someone will need to update MSVC to have similar behavior.

Which is what? :-)

It just needs to set HAVE_FSEEKO to 1 in pg_config.h?

//Magnus

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Martin Pihlak 2009-01-07 10:36:50 Re: reducing statistics write overhead
Previous Message Simon Riggs 2009-01-07 09:54:44 Re: Latest version of Hot Standby patch