Re: warn in plperl logs as... NOTICE??

From: Alexey Klyukin <alexk(at)waki(dot)ru>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jim Nasby <jim(at)nasby(dot)net>, "pgsql-hackers(at)postgresql(dot)org Hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: warn in plperl logs as... NOTICE??
Date: 2010-01-22 14:13:32
Message-ID: 45593949-0BE4-47D8-9FA7-3563DC059DAF@waki.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On Jan 22, 2010, at 2:55 AM, Andrew Dunstan wrote:

>
>
> Tom Lane wrote:
>> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>>
>>> Jim Nasby wrote:
>>>
>>>> Why does warn; in plperl log as NOTICE in Postgres?
>>>>
>>
>>
>>> Where would you like the warning to go? This has been this way for nearly 5 years, it's not new (and before that the warning didn't go anywhere).
>>>
>>
>> I think he's suggesting that it ought to translate as elog(WARNING)
>> not elog(NOTICE).
>>
>>
>>
>
> *shrug* I don't have a strong opinion about it, and it's pretty easy to change, if there's a consensus we should. I have certainly found over the years that perl warnings from some modules can be annoyingly verbose, which is probably why the original patch didn't make them have a higher level in Postgres. If this were a big issue we'd have surely heard about it before now - there are plenty of plperl users out there.

I think elog(WARNING) is less surprising for the end-user, unless there's an objection strong enough to include it into the documentation :)

--
Alexey Klyukin http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Meskes 2010-01-22 14:18:44 Re: Fix auto-prepare #2
Previous Message Robert Haas 2010-01-22 14:10:54 Re: commit fests (was Re: primary key error message)