Re: [HACKERS] For review: Server instrumentation patch

From: Andreas Pflug <pgadmin(at)pse-consulting(dot)de>
To: Dave Page <dpage(at)vale-housing(dot)co(dot)uk>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] For review: Server instrumentation patch
Date: 2005-08-01 13:46:36
Message-ID: 42EE27BC.5080407@pse-consulting.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Dave Page wrote:
>
>
>
>>-----Original Message-----
>>From: Bruce Momjian [mailto:pgman(at)candle(dot)pha(dot)pa(dot)us]
>>Sent: 01 August 2005 03:26
>>To: Dave Page
>>Cc: PostgreSQL-patches
>>Subject: Re: [HACKERS] For review: Server instrumentation patch
>>
>>Dave Page wrote:
>>
>>>[Resent as the list seems to have rejected yesterdays attempt]
>>>
>>>As per Bruce's request, here's a copy of Andreas' server
>>>instrumentation patch for review. I've separated out the
>>>dbsize stuff and pg_terminate_backend is also not included.
>>>
>>>This version was generated against CVS today.
>>>
>>>As far as I can tell from review of comments made back to
>>>pre-8.0, all security and other concerns raised have been addressed.
>>
>>Here is a modified version of your patch that adds functions to do
>>configuration file reload, and log file rotation.
>
>
> OK, thanks. Are there any objections to adding pg_dir_ls() and
> pg_file_read() which will allow us to look at the log directory, and the
> logfiles themselves?

pg_dir_ls isn't necessary for reading the logfiles; pg_logdir_ls will do
this.

Regards,
Andreas

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Dave Page 2005-08-01 13:54:38 Re: [HACKERS] For review: Server instrumentation patch
Previous Message Alvaro Herrera 2005-08-01 13:14:24 Re: [HACKERS] Autovacuum loose ends