Re: [HACKERS] Re: datetime regress test busted by incomplete checkin

From: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
To: phd2(at)earthling(dot)net
Cc: tgl(at)sss(dot)pgh(dot)pa(dot)us, hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] Re: datetime regress test busted by incomplete checkin
Date: 1999-01-25 18:04:12
Message-ID: 199901251804.NAA26674@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Applied. Sorry.

> Hello!
>
> On Sat, 23 Jan 1999, Bruce Momjian wrote:
>
> > > Someone (you, according to the cvs logs) checked in an update to the
> > > "expected" file for the datetime regress test, but didn't check in the
> > > corresponding update to the test file itself. sql/datetime.sql is
> > > still dated 1997 ...
> >
> > It came from someone, not sure who. Can someone comment? If not, let's
> > back it out.
> >
> > --
> > Bruce Momjian | http://www.op.net/~candle
> > maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
> > + If your life is a hard drive, | 830 Blythe Avenue
> > + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
>
> Probably that's me. The patch attached. Is there any problem?
>
> Oleg.
> ----
> Oleg Broytmann http://members.tripod.com/~phd2/ phd2(at)earthling(dot)net
> Programmers don't die, they just GOSUB without RETURN.
Content-Description:

> *** ./src/test/regress/expected/datetime.out.orig Mon Jan 5 06:35:27 1998
> --- ./src/test/regress/expected/datetime.out Wed Jan 6 12:50:50 1999
> ***************
> *** 28,33 ****
> --- 28,40 ----
> @ 0
> (1 row)
>
> + QUERY: SET DateStyle = 'Postgres,noneuropean';
> + QUERY: SELECT datetime('1994-01-01', '11:00') AS "Jan_01_1994_11am";
> + Jan_01_1994_11am
> + ----------------------------
> + Sat Jan 01 11:00:00 1994 PST
> + (1 row)
> +
> QUERY: CREATE TABLE DATETIME_TBL( d1 datetime);
> QUERY: INSERT INTO DATETIME_TBL VALUES ('current');
> QUERY: INSERT INTO DATETIME_TBL VALUES ('today');
> *** ./src/test/regress/sql/datetime.sql.orig Sat Nov 15 05:55:57 1997
> --- ./src/test/regress/sql/datetime.sql Wed Jan 6 12:49:23 1999
> ***************
> *** 10,15 ****
> --- 10,18 ----
> SELECT ('current'::datetime = 'now'::datetime) as "True";
> SELECT ('now'::datetime - 'current'::datetime) AS "ZeroSecs";
>
> + SET DateStyle = 'Postgres,noneuropean';
> + SELECT datetime('1994-01-01', '11:00') AS "Jan_01_1994_11am";
> +
> CREATE TABLE DATETIME_TBL( d1 datetime);
>
> INSERT INTO DATETIME_TBL VALUES ('current');
>

--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message The Hermit Hacker 1999-01-25 18:27:32 Re: [HACKERS] Another source of snprintf/vsnprintf code
Previous Message Dan Gowin 1999-01-25 17:06:37 FW: [CORE] create database bug