| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Re: [COMMITTERS] pgsql: Derived files that are shipped in the distribution used to be |
| Date: | 2009-09-02 19:05:48 |
| Message-ID: | 15269.1251918348@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> On ons, 2009-09-02 at 19:24 +0200, Magnus Hagander wrote:
>> -kwlookup.c: % : ../../../backend/parser/%
>> +kwlookup.c: % : $(top_srcdir)/src/backend/parser/%
>> rm -f $@ && $(LN_S) $< .
> I think you can revert this if it helps you, although it's not clear to
> me why it would make a difference one way or the other.
It looks to me like Magnus' git tool has gotten the direction of the
change backwards --- $(top_srcdir) was the old coding, which was like
every other place that is symlinking something, and the new ../../ bit
is gratuitously unlike the rest. I imagine the point is that the MSVC
scripts only know how to deal with the $(top_srcdir) form.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2009-09-02 19:08:46 | Re: Re: [COMMITTERS] pgsql: Derived files that are shipped in the distribution used to be |
| Previous Message | Peter Eisentraut | 2009-09-02 18:56:42 | Re: [COMMITTERS] pgsql: Derived files that are shipped in the distribution used to be |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2009-09-02 19:08:46 | Re: Re: [COMMITTERS] pgsql: Derived files that are shipped in the distribution used to be |
| Previous Message | Robert Haas | 2009-09-02 19:04:27 | Re: remove flatfiles.c |