Re: [COMMITTERS] pgsql: Derived files that are shipped in the distribution used to be

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Derived files that are shipped in the distribution used to be
Date: 2009-09-02 18:56:42
Message-ID: 1251917802.30166.3.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On ons, 2009-09-02 at 19:24 +0200, Magnus Hagander wrote:
> On Sat, Aug 29, 2009 at 05:26, Tom Lane<tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > petere(at)postgresql(dot)org (Peter Eisentraut) writes:
> >> Log Message:
> >> -----------
> >> Derived files that are shipped in the distribution used to be built in the
> >> source directory even for out-of-tree builds. They are now alsl built in
> >> the build tree. This should be more convenient for certain developers'
> >> workflows, and shouldn't really break anything else.
> >
> > Seems to have broken the MSVC build ...
>
> This is the part that broke it:
> diff --git a/src/interfaces/ecpg/preproc/Makefile
> b/src/interfaces/ecpg/preproc/Makefile
> index fc7dcf5..f14a833 100644
> --- a/src/interfaces/ecpg/preproc/Makefile
> +++ b/src/interfaces/ecpg/preproc/Makefile
> @@ -57,7 +57,7 @@ preproc.y: ../../../backend/parser/gram.y parse.pl
> ecpg.addons ecpg.header ecpg.
>
> ecpg_keywords.o c_keywords.o keywords.o preproc.o parser.o: preproc.h
>
> -kwlookup.c: % : ../../../backend/parser/%
> +kwlookup.c: % : $(top_srcdir)/src/backend/parser/%
> rm -f $@ && $(LN_S) $< .
>
> distprep: preproc.y preproc.c preproc.h pgc.c

I think you can revert this if it helps you, although it's not clear to
me why it would make a difference one way or the other.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2009-09-02 19:05:48 Re: Re: [COMMITTERS] pgsql: Derived files that are shipped in the distribution used to be
Previous Message Tom Lane 2009-09-02 17:52:33 pgsql: Fix subquery pullup to wrap a PlaceHolderVar around the entire

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Stark 2009-09-02 19:01:06 Re: remove flatfiles.c
Previous Message Tom Lane 2009-09-02 18:54:40 Re: remove flatfiles.c